Compare commits

...
2 Commits
Author SHA1 Message Date
TZGyn f50057d951 Fix screenshot offset after pixel-exact crop change
The new CGImage.cropping path expects a top-left pixel rect; the previous
CGContext redraw had implicitly flipped Y. Keep the existing SCDisplay-space
conversion so the crop matches the selected region.

💘 Generated with Crush

Assisted-by: Crush:deepseek-v4-flash-0731
2026-08-23 13:23:37 +08:00
TZGyn 16b876807d Add freehand drawing and fix residual capture pixelation
The screenshot window now supports toggling a pen to draw annotations
that are flattened into copied and saved images. Captures are also
cropped with a pixel-exact CGImage.cropping instead of a CGContext
redraw, removing residual blur on retina displays.

💘 Generated with Crush

Assisted-by: Crush:deepseek-v4-flash-0731
2026-08-23 13:21:22 +08:00
3 changed files with 135 additions and 25 deletions
+8 -9
View File
@@ -124,6 +124,9 @@ final class ScreenCapture {
let scaleX = CGFloat(image.width) / display.frame.width let scaleX = CGFloat(image.width) / display.frame.width
let scaleY = CGFloat(image.height) / display.frame.height let scaleY = CGFloat(image.height) / display.frame.height
guard scaleX > 0, scaleY > 0 else { return nil } guard scaleX > 0, scaleY > 0 else { return nil }
// pxRect is in image pixel space with a TOP-LEFT origin (SCDisplay space).
// CGImage.cropping(to:) expects the same top-left rect, so no Y flip
// is needed here — this preserves the previous CGContext behavior.
let pxRect = CGRect( let pxRect = CGRect(
x: (cgRect.minX - display.frame.minX) * scaleX, x: (cgRect.minX - display.frame.minX) * scaleX,
y: (cgRect.minY - display.frame.minY) * scaleY, y: (cgRect.minY - display.frame.minY) * scaleY,
@@ -134,15 +137,11 @@ final class ScreenCapture {
// display's frame (e.g. secondary monitor coordinate quirks). // display's frame (e.g. secondary monitor coordinate quirks).
let safeRect = pxRect.intersection(CGRect(x: 0, y: 0, width: CGFloat(image.width), height: CGFloat(image.height))) let safeRect = pxRect.intersection(CGRect(x: 0, y: 0, width: CGFloat(image.width), height: CGFloat(image.height)))
guard safeRect.width >= 1, safeRect.height >= 1 else { return nil } guard safeRect.width >= 1, safeRect.height >= 1 else { return nil }
guard let cropCtx = CGContext( // Use a pixel-exact subimage crop instead of redrawing through a
data: nil, width: Int(safeRect.width), height: Int(safeRect.height), // CGContext, which resamples and loses quality on retina captures.
bitsPerComponent: 8, bytesPerRow: 0, let rounded = safeRect.integral
space: CGColorSpaceCreateDeviceRGB(), guard rounded.width >= 1, rounded.height >= 1 else { return nil }
bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue return image.cropping(to: rounded)
) else { return nil }
cropCtx.interpolationQuality = .high
cropCtx.draw(image, in: CGRect(x: -safeRect.minX, y: -safeRect.minY, width: CGFloat(image.width), height: CGFloat(image.height)))
return cropCtx.makeImage()
} }
@available(macOS 14.0, *) @available(macOS 14.0, *)
+125 -14
View File
@@ -90,6 +90,10 @@ final class CaptureModel: ObservableObject {
@Published var statusMessage: String? @Published var statusMessage: String?
/// Drag selection rect in IMAGE point space (nil = none) /// Drag selection rect in IMAGE point space (nil = none)
@Published var selection: CGRect? @Published var selection: CGRect?
/// Freehand drawing strokes in IMAGE point space
@Published var strokes: [[CGPoint]] = []
/// Whether the pen is active (drag draws instead of selecting)
@Published var isDrawing = false
enum CaptureMode { enum CaptureMode {
case screenshot case screenshot
@@ -102,6 +106,46 @@ final class CaptureModel: ObservableObject {
var hasSelection: Bool { selection != nil && selection!.width >= 2 && selection!.height >= 2 } var hasSelection: Bool { selection != nil && selection!.width >= 2 && selection!.height >= 2 }
/// Image with drawn strokes flattened in, for copy/save/export.
var annotatedImage: CGImage {
guard !strokes.isEmpty else { return image }
let size = NSSize(width: image.width, height: image.height)
guard let rep = NSBitmapImageRep(
bitmapDataPlanes: nil, pixelsWide: Int(size.width), pixelsHigh: Int(size.height),
bitsPerSample: 8, samplesPerPixel: 4, hasAlpha: true, isPlanar: false,
colorSpaceName: .deviceRGB, bytesPerRow: 0, bitsPerPixel: 0
) else { return image }
NSGraphicsContext.saveGraphicsState()
NSGraphicsContext.current = NSGraphicsContext(bitmapImageRep: rep)
let ctx = NSGraphicsContext.current!.cgContext
// CGImage draws with a flipped Y in NSGraphicsContext
ctx.draw(image, in: NSRect(origin: .zero, size: size))
NSColor.systemRed.setStroke()
ctx.setLineWidth(3)
ctx.setLineCap(.round)
ctx.setLineJoin(.round)
for stroke in strokes {
guard stroke.count > 1 else { continue }
ctx.beginPath()
ctx.move(to: stroke[0])
for point in stroke.dropFirst() {
ctx.addLine(to: point)
}
ctx.strokePath()
}
NSGraphicsContext.restoreGraphicsState()
return rep.cgImage ?? image
}
func addStroke(_ points: [CGPoint]) {
guard points.count > 1 else { return }
strokes.append(points)
}
func clearAnnotations() {
strokes = []
}
var displayText: String { var displayText: String {
if isOCRRunning { if isOCRRunning {
return "Recognizing text…" return "Recognizing text…"
@@ -164,7 +208,7 @@ final class CaptureModel: ObservableObject {
func copyImage() { func copyImage() {
let pasteboard = NSPasteboard.general let pasteboard = NSPasteboard.general
pasteboard.clearContents() pasteboard.clearContents()
pasteboard.writeObjects([NSImage(cgImage: image, size: .zero)]) pasteboard.writeObjects([NSImage(cgImage: annotatedImage, size: .zero)])
statusMessage = "Image copied to clipboard." statusMessage = "Image copied to clipboard."
} }
@@ -177,7 +221,7 @@ final class CaptureModel: ObservableObject {
statusMessage = "Could not create PNG file." statusMessage = "Could not create PNG file."
return return
} }
CGImageDestinationAddImage(dest, image, nil) CGImageDestinationAddImage(dest, annotatedImage, nil)
if CGImageDestinationFinalize(dest) { if CGImageDestinationFinalize(dest) {
statusMessage = "Saved PNG." statusMessage = "Saved PNG."
} else { } else {
@@ -231,6 +275,27 @@ struct ResultView: View {
Divider().frame(height: 18) Divider().frame(height: 18)
Button {
model.isDrawing.toggle()
if model.isDrawing { model.selection = nil }
} label: {
Label("Draw", systemImage: model.isDrawing ? "pencil.tip.crop.circle.fill" : "pencil.tip.crop.circle")
}
.buttonStyle(.bordered)
.foregroundStyle(model.isDrawing ? .primary : .secondary)
.help("Toggle drawing on the screenshot")
if !model.strokes.isEmpty {
Button {
model.clearAnnotations()
} label: {
Label("Clear", systemImage: "eraser")
}
.buttonStyle(.bordered)
.foregroundStyle(.secondary)
.help("Remove all drawn annotations")
}
Button { Button {
model.copyImage() model.copyImage()
} label: { } label: {
@@ -340,6 +405,8 @@ struct ScreenshotPane: View {
rect.intersection(CGRect(origin: .zero, size: imageSize)) rect.intersection(CGRect(origin: .zero, size: imageSize))
} }
@State private var currentStroke: [CGPoint] = []
var body: some View { var body: some View {
GeometryReader { geo in GeometryReader { geo in
let (scale, drawSize, origin) = geometry(for: geo) let (scale, drawSize, origin) = geometry(for: geo)
@@ -352,7 +419,36 @@ struct ScreenshotPane: View {
.frame(width: drawSize.width, height: drawSize.height) .frame(width: drawSize.width, height: drawSize.height)
.position(x: origin.x + drawSize.width / 2, y: origin.y + drawSize.height / 2) .position(x: origin.x + drawSize.width / 2, y: origin.y + drawSize.height / 2)
if let sel = model.selection { // Completed strokes
Canvas { context, _ in
var path = Path()
for stroke in model.strokes {
guard stroke.count > 1 else { continue }
path.move(to: CGPoint(x: origin.x + stroke[0].x * scale, y: origin.y + stroke[0].y * scale))
for point in stroke.dropFirst() {
path.addLine(to: CGPoint(x: origin.x + point.x * scale, y: origin.y + point.y * scale))
}
}
context.stroke(path, with: .color(.red), lineWidth: 2.5)
}
.allowsHitTesting(false)
// In-progress stroke
if !currentStroke.isEmpty {
Canvas { context, _ in
var path = Path()
if currentStroke.count > 1 {
path.move(to: CGPoint(x: origin.x + currentStroke[0].x * scale, y: origin.y + currentStroke[0].y * scale))
for point in currentStroke.dropFirst() {
path.addLine(to: CGPoint(x: origin.x + point.x * scale, y: origin.y + point.y * scale))
}
}
context.stroke(path, with: .color(.red), lineWidth: 2.5)
}
.allowsHitTesting(false)
}
if !model.isDrawing, let sel = model.selection {
let viewRect = CGRect( let viewRect = CGRect(
x: origin.x + sel.minX * scale, x: origin.x + sel.minX * scale,
y: origin.y + sel.minY * scale, y: origin.y + sel.minY * scale,
@@ -371,19 +467,34 @@ struct ScreenshotPane: View {
.gesture( .gesture(
DragGesture(minimumDistance: 0) DragGesture(minimumDistance: 0)
.onChanged { value in .onChanged { value in
let start = toImagePoint(value.startLocation, scale: scale, origin: origin) if model.isDrawing {
let current = toImagePoint(value.location, scale: scale, origin: origin) let p = toImagePoint(value.location, scale: scale, origin: origin)
let rect = CGRect( let imgRect = CGRect(origin: .zero, size: imageSize)
x: min(start.x, current.x), if imgRect.contains(p) {
y: min(start.y, current.y), currentStroke.append(p)
width: abs(current.x - start.x), }
height: abs(current.y - start.y) } else {
) let start = toImagePoint(value.startLocation, scale: scale, origin: origin)
model.selection = clampSelection(rect) let current = toImagePoint(value.location, scale: scale, origin: origin)
let rect = CGRect(
x: min(start.x, current.x),
y: min(start.y, current.y),
width: abs(current.x - start.x),
height: abs(current.y - start.y)
)
model.selection = clampSelection(rect)
}
} }
.onEnded { _ in .onEnded { _ in
if let s = model.selection, (s.width < 2 || s.height < 2) { if model.isDrawing {
model.selection = nil if currentStroke.count > 1 {
model.addStroke(currentStroke)
}
currentStroke = []
} else {
if let s = model.selection, (s.width < 2 || s.height < 2) {
model.selection = nil
}
} }
} }
) )
+2 -2
View File
@@ -108,9 +108,9 @@ cat > "$APP/Contents/Info.plist" <<'PLIST'
<key>CFBundleIconFile</key> <key>CFBundleIconFile</key>
<string>Icon</string> <string>Icon</string>
<key>CFBundleShortVersionString</key> <key>CFBundleShortVersionString</key>
<string>1.2.1</string> <string>1.3.1</string>
<key>CFBundleVersion</key> <key>CFBundleVersion</key>
<string>21</string> <string>31</string>
<key>LSUIElement</key> <key>LSUIElement</key>
<true/> <true/>
<key>NSHighResolutionCapable</key> <key>NSHighResolutionCapable</key>