Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
715bb28c1b | ||
|
|
07642ca408 | ||
|
|
924a692f2b | ||
|
|
ae054d70b9 | ||
|
|
3078713f8f | ||
|
|
265571d7e2 | ||
|
|
7633e81c52 | ||
|
|
83b127cf44 | ||
|
|
8332661504 | ||
|
|
832a18b06c |
@@ -14,8 +14,9 @@ final class CaptureController: NSObject {
|
||||
// Selection state (driven by the event tap; AppKit global coordinates)
|
||||
private var marqueeStart: NSPoint?
|
||||
private(set) var marqueeRect: NSRect?
|
||||
private(set) var hoverFrame: NSRect?
|
||||
private var trackedWindows: [(id: CGWindowID, frame: NSRect)] = []
|
||||
private(set) var hoverWindow: (id: CGWindowID, frame: NSRect, pid: Int)?
|
||||
var hoverFrame: NSRect? { hoverWindow?.frame }
|
||||
private var trackedWindows: [(id: CGWindowID, frame: NSRect, pid: Int)] = []
|
||||
private var lastWindowScan = Date.distantPast
|
||||
private var eventTap: CFMachPort?
|
||||
|
||||
@@ -102,14 +103,19 @@ final class CaptureController: NSObject {
|
||||
}
|
||||
}
|
||||
|
||||
/// A window was picked from hover — capture it with rounded corners.
|
||||
private func finishWindowPick(_ rect: NSRect) {
|
||||
/// A window was picked from hover — capture it directly (real rounded
|
||||
/// corners come from the window's own alpha).
|
||||
private func finishWindowPick(_ windowID: CGWindowID, _ rect: NSRect, ownedRisk: Bool) {
|
||||
let ids = overlayIDs
|
||||
hideOverlays()
|
||||
isSelecting = false
|
||||
restorePreviousApp()
|
||||
DispatchQueue.main.async { [self] in
|
||||
capture(rect, excludingWindowIDs: ids, roundedCorners: true)
|
||||
if ownedRisk {
|
||||
capture(rect, excludingWindowIDs: ids, roundedCorners: true)
|
||||
} else {
|
||||
capture(rect, excludingWindowIDs: ids, windowID: windowID)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -136,7 +142,7 @@ final class CaptureController: NSObject {
|
||||
overlays.forEach { $0.orderOut(nil) }
|
||||
overlays = []
|
||||
marqueeRect = nil
|
||||
hoverFrame = nil
|
||||
hoverWindow = nil
|
||||
marqueeStart = nil
|
||||
}
|
||||
|
||||
@@ -217,11 +223,12 @@ final class CaptureController: NSObject {
|
||||
) as? [[String: Any]] else { trackedWindows = []; return }
|
||||
|
||||
let ownIDs = Set(overlayIDs)
|
||||
var found: [(id: CGWindowID, frame: NSRect)] = []
|
||||
var found: [(id: CGWindowID, frame: NSRect, pid: Int)] = []
|
||||
for info in list {
|
||||
guard let cid = info[kCGWindowNumber as String] as? CGWindowID,
|
||||
let bounds = info[kCGWindowBounds as String] as? [String: CGFloat],
|
||||
let layer = info[kCGWindowLayer as String] as? Int,
|
||||
let pid = info[kCGWindowOwnerPID as String] as? Int,
|
||||
layer == 0
|
||||
else { continue }
|
||||
if ownIDs.contains(Int(cid)) { continue }
|
||||
@@ -233,12 +240,7 @@ final class CaptureController: NSObject {
|
||||
)
|
||||
guard cgRect.width >= 80, cgRect.height >= 60 else { continue }
|
||||
let rect = Self.cgToAppKit(rect: cgRect)
|
||||
// Skip windows filling an entire screen (fullscreen apps)
|
||||
let coversWholeScreen = NSScreen.screens.contains { screen in
|
||||
abs(screen.frame.width - rect.width) < 2 && abs(screen.frame.height - rect.height) < 2
|
||||
}
|
||||
guard !coversWholeScreen else { continue }
|
||||
found.append((cid, rect))
|
||||
found.append((id: cid, frame: rect, pid: pid))
|
||||
}
|
||||
trackedWindows = found
|
||||
}
|
||||
@@ -251,10 +253,10 @@ final class CaptureController: NSObject {
|
||||
return NSRect(x: rect.origin.x, y: y, width: rect.width, height: rect.height)
|
||||
}
|
||||
|
||||
private func topmostWindowContaining(_ appKitPoint: NSPoint) -> NSRect? {
|
||||
for (_, frame) in trackedWindows {
|
||||
if frame.contains(appKitPoint) {
|
||||
return frame
|
||||
private func topmostWindowContaining(_ appKitPoint: NSPoint) -> (id: CGWindowID, frame: NSRect, pid: Int)? {
|
||||
for entry in trackedWindows {
|
||||
if entry.frame.contains(appKitPoint) {
|
||||
return entry
|
||||
}
|
||||
}
|
||||
return nil
|
||||
@@ -265,11 +267,12 @@ final class CaptureController: NSObject {
|
||||
guard isSelecting else { return event }
|
||||
|
||||
switch type {
|
||||
case .tapDisabledByUserInput:
|
||||
CGEvent.tapEnable(tap: eventTap!, enable: true)
|
||||
return event
|
||||
case .tapDisabledByTimeout:
|
||||
CGEvent.tapEnable(tap: eventTap!, enable: true)
|
||||
case .tapDisabledByUserInput, .tapDisabledByTimeout:
|
||||
// A timed-out tap must be re-enabled; guard against a torn-down tap.
|
||||
if let tap = eventTap {
|
||||
CGEvent.tapEnable(tap: tap, enable: true)
|
||||
CaptureController.log("tap: re-enabled after \(type)")
|
||||
}
|
||||
return event
|
||||
case .keyDown:
|
||||
if event.getIntegerValueField(.keyboardEventKeycode) == 53 {
|
||||
@@ -286,15 +289,23 @@ final class CaptureController: NSObject {
|
||||
}
|
||||
let appKitPoint = cgPointToAppKit(NSPoint(x: event.location.x, y: event.location.y))
|
||||
if type == .mouseMoved {
|
||||
let frame = topmostWindowContaining(appKitPoint)
|
||||
if frame != hoverFrame {
|
||||
hoverFrame = frame
|
||||
let window = topmostWindowContaining(appKitPoint)
|
||||
if window?.frame != hoverFrame {
|
||||
hoverWindow = window
|
||||
if let w = window {
|
||||
CaptureController.log("hover: picked id=\(w.id) frame=\(w.frame) (tracked=\(trackedWindows.count))")
|
||||
} else {
|
||||
CaptureController.log("hover: none (tracked=\(trackedWindows.count))")
|
||||
}
|
||||
renderOverlays()
|
||||
}
|
||||
return event
|
||||
}
|
||||
// Drag: grow the marquee
|
||||
// Drag: grow the marquee — but only after real movement, so a
|
||||
// click's micro-jitter keeps the hovered window eligible.
|
||||
guard let start = marqueeStart else { return nil }
|
||||
let distance = hypot(appKitPoint.x - start.x, appKitPoint.y - start.y)
|
||||
guard distance >= 4 else { return nil }
|
||||
let rect = NSRect(
|
||||
x: min(start.x, appKitPoint.x),
|
||||
y: min(start.y, appKitPoint.y),
|
||||
@@ -302,7 +313,7 @@ final class CaptureController: NSObject {
|
||||
height: abs(appKitPoint.y - start.y)
|
||||
)
|
||||
marqueeRect = rect
|
||||
hoverFrame = nil
|
||||
hoverWindow = nil
|
||||
renderOverlays()
|
||||
return nil
|
||||
case .leftMouseDown:
|
||||
@@ -317,9 +328,18 @@ final class CaptureController: NSObject {
|
||||
if let rect = marqueeRect, dragDistance >= 4, rect.width >= 2, rect.height >= 2 {
|
||||
CaptureController.log("tap: marquee complete \(rect)")
|
||||
finishSelection(rect)
|
||||
} else if let hover = hoverFrame {
|
||||
CaptureController.log("tap: window pick \(hover)")
|
||||
finishWindowPick(hover)
|
||||
} else if let hover = hoverWindow {
|
||||
// An overlapping window from the same app means this is an
|
||||
// owned popup — desktopIndependentWindow would composite the
|
||||
// parent too, so capture the screen crop instead.
|
||||
// Owned popups composite their parent even when the windows
|
||||
// don't overlap, so ANY other same-app window on screen means
|
||||
// crop (correct region) instead of the group composite.
|
||||
let ownedRisk = trackedWindows.contains {
|
||||
$0.id != hover.id && $0.pid == hover.pid
|
||||
}
|
||||
CaptureController.log("tap: window pick id=\(hover.id) pid=\(hover.pid) ownedRisk=\(ownedRisk) \(hover.frame)")
|
||||
finishWindowPick(hover.id, hover.frame, ownedRisk: ownedRisk)
|
||||
} else {
|
||||
CaptureController.log("tap: click with no hover/marquee — cancel")
|
||||
cancelSelection()
|
||||
@@ -332,8 +352,8 @@ final class CaptureController: NSObject {
|
||||
|
||||
// MARK: - Capture
|
||||
|
||||
private func capture(_ rect: NSRect, excludingWindowIDs ids: [Int], roundedCorners: Bool = false) {
|
||||
ScreenCapture.shared.capture(rect, excludingWindowIDs: ids, roundedCorners: roundedCorners) { [weak self] image in
|
||||
private func capture(_ rect: NSRect, excludingWindowIDs ids: [Int], roundedCorners: Bool = false, windowID: CGWindowID? = nil) {
|
||||
ScreenCapture.shared.capture(rect, excludingWindowIDs: ids, roundedCorners: roundedCorners, windowID: windowID) { [weak self] image in
|
||||
DispatchQueue.main.async {
|
||||
self?.isSelecting = false
|
||||
self?.restorePreviousApp()
|
||||
@@ -342,6 +362,7 @@ final class CaptureController: NSObject {
|
||||
ResultWindow.shared.show(image: ResultWindow.failureImage("Capture failed. Check Screen Recording permission."))
|
||||
return
|
||||
}
|
||||
CaptureController.log("capture done: \(image.width)x\(image.height) — showing result window")
|
||||
ResultWindow.shared.show(image: image)
|
||||
}
|
||||
}
|
||||
@@ -354,6 +375,41 @@ final class ScreenCapture {
|
||||
|
||||
private init() {}
|
||||
|
||||
/// Estimate the window's corner radius (in image pixels) by scanning the
|
||||
/// top-left corner: the crop's corner pixels are the desktop background;
|
||||
/// app content starts where the color departs from it.
|
||||
static func detectCornerRadius(of image: CGImage) -> CGFloat? {
|
||||
let w = image.width, h = image.height
|
||||
guard w > 30, h > 30 else { return nil }
|
||||
var px = [UInt8](repeating: 0, count: w * h * 4)
|
||||
guard let c = CGContext(data: &px, width: w, height: h, bitsPerComponent: 8, bytesPerRow: w * 4,
|
||||
space: CGColorSpaceCreateDeviceRGB(),
|
||||
bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue) else { return nil }
|
||||
c.draw(image, in: CGRect(x: 0, y: 0, width: w, height: h))
|
||||
|
||||
func pixel(x: Int, yTop: Int) -> (r: Int, g: Int, b: Int) {
|
||||
let row = yTop * w * 4 + x * 4
|
||||
return (Int(px[row]), Int(px[row + 1]), Int(px[row + 2]))
|
||||
}
|
||||
let bg = pixel(x: 0, yTop: 0)
|
||||
func diffFromBg(_ p: (r: Int, g: Int, b: Int)) -> Int {
|
||||
abs(p.r - bg.r) + abs(p.g - bg.g) + abs(p.b - bg.b)
|
||||
}
|
||||
var radii: [CGFloat] = []
|
||||
for (limit, axis) in [(h / 3, 0), (w / 3, 1)] {
|
||||
for i in 0..<limit {
|
||||
let p = axis == 0 ? pixel(x: 0, yTop: i) : pixel(x: i, yTop: 0)
|
||||
if diffFromBg(p) > 24 {
|
||||
radii.append(CGFloat(i))
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
guard radii.count == 2 else { return nil }
|
||||
let r = (radii[0] + radii[1]) / 2
|
||||
return (r >= 3 && r <= 40) ? r : nil
|
||||
}
|
||||
|
||||
@available(macOS 14.0, *)
|
||||
private func crop(_ image: CGImage, to cgRect: CGRect, display: SCDisplay, roundedCorners: Bool = false) -> CGImage? {
|
||||
// cgRect is in SCDisplay space (bottom-left origin, Y flipped vs AppKit).
|
||||
@@ -384,23 +440,49 @@ final class ScreenCapture {
|
||||
// Apply a rounded-corner alpha mask for window captures, matching
|
||||
// macOS window chrome (≈10pt radius, scaled to image pixels).
|
||||
if roundedCorners {
|
||||
let radius = 10 * scaleX
|
||||
let maskRect = CGRect(x: 0, y: 0, width: result.width, height: result.height)
|
||||
guard let maskCtx = CGContext(
|
||||
// The screen crop contains the app's real rounded corners against
|
||||
// the desktop — measure the radius from the corner pixels, then
|
||||
// mask with it (supersampled for smooth edges).
|
||||
let detected = Self.detectCornerRadius(of: result)
|
||||
let radius = min(max((detected.map { $0 * 1.23 + 2.6 }) ?? (10 * scaleX), 4), 40)
|
||||
CaptureController.log("corners: detected=\(detected.map { String(format: "%.1f", $0) } ?? "nil") using=\(Int(radius))px")
|
||||
// Anti-aliased gray mask: supersample 3x, downsample, then draw
|
||||
// the image through it ONCE at 1x (no content resampling blur).
|
||||
let ss = 3
|
||||
let W = result.width * ss, H = result.height * ss
|
||||
guard let hiMask = CGContext(
|
||||
data: nil, width: W, height: H,
|
||||
bitsPerComponent: 8, bytesPerRow: 0,
|
||||
space: CGColorSpaceCreateDeviceGray(),
|
||||
bitmapInfo: CGImageAlphaInfo.none.rawValue
|
||||
) else { return result }
|
||||
hiMask.setFillColor(CGColor(gray: 1, alpha: 1))
|
||||
hiMask.fill(CGRect(x: 0, y: 0, width: W, height: H))
|
||||
hiMask.setFillColor(CGColor(gray: 0, alpha: 1))
|
||||
let cornerPath = CGMutablePath()
|
||||
cornerPath.addRect(CGRect(x: 0, y: 0, width: W, height: H))
|
||||
cornerPath.addRoundedRect(in: CGRect(x: 0, y: 0, width: W, height: H), cornerWidth: radius * CGFloat(ss), cornerHeight: radius * CGFloat(ss), transform: .identity)
|
||||
hiMask.addPath(cornerPath)
|
||||
hiMask.fillPath(using: .evenOdd)
|
||||
guard let hiMaskImg = hiMask.makeImage(),
|
||||
let downMask = CGContext(
|
||||
data: nil, width: result.width, height: result.height,
|
||||
bitsPerComponent: 8, bytesPerRow: 0,
|
||||
space: CGColorSpaceCreateDeviceGray(),
|
||||
bitmapInfo: CGImageAlphaInfo.none.rawValue
|
||||
) else { return result }
|
||||
downMask.interpolationQuality = .high
|
||||
downMask.draw(hiMaskImg, in: CGRect(x: 0, y: 0, width: result.width, height: result.height))
|
||||
guard let mask1x = downMask.makeImage(),
|
||||
let ctx = CGContext(
|
||||
data: nil, width: result.width, height: result.height,
|
||||
bitsPerComponent: 8, bytesPerRow: 0,
|
||||
space: CGColorSpaceCreateDeviceRGB(),
|
||||
bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue
|
||||
) else { return result }
|
||||
maskCtx.setFillColor(CGColor(gray: 1, alpha: 1))
|
||||
maskCtx.fill(maskRect)
|
||||
maskCtx.setBlendMode(.clear)
|
||||
maskCtx.setFillColor(CGColor(gray: 0, alpha: 1))
|
||||
maskCtx.addPath(CGPath(roundedRect: maskRect, cornerWidth: radius, cornerHeight: radius, transform: nil))
|
||||
maskCtx.fillPath()
|
||||
maskCtx.setBlendMode(.normal)
|
||||
if let mask = maskCtx.makeImage(),
|
||||
let masked = result.masking(mask) {
|
||||
ctx.clip(to: CGRect(x: 0, y: 0, width: result.width, height: result.height), mask: mask1x)
|
||||
ctx.draw(result, in: CGRect(x: 0, y: 0, width: result.width, height: result.height))
|
||||
if let masked = ctx.makeImage() {
|
||||
result = masked
|
||||
}
|
||||
}
|
||||
@@ -417,7 +499,7 @@ final class ScreenCapture {
|
||||
return content.displays.first(where: { $0.displayID == cgID }) ?? content.displays.first
|
||||
}
|
||||
|
||||
func capture(_ rect: NSRect, excludingWindowIDs excludedIDs: [Int], roundedCorners: Bool = false, completion: @escaping (CGImage?) -> Void) {
|
||||
func capture(_ rect: NSRect, excludingWindowIDs excludedIDs: [Int], roundedCorners: Bool = false, windowID: CGWindowID? = nil, completion: @escaping (CGImage?) -> Void) {
|
||||
if #available(macOS 14.0, *) {
|
||||
Task {
|
||||
guard let content = try? await SCShareableContent.current,
|
||||
@@ -440,7 +522,7 @@ final class ScreenCapture {
|
||||
let backingScale = screen.backingScaleFactor
|
||||
config.width = Int(CGFloat(display.width) * backingScale)
|
||||
config.height = Int(CGFloat(display.height) * backingScale)
|
||||
config.showsCursor = true
|
||||
config.showsCursor = false
|
||||
|
||||
// ScreenCaptureKit uses a different origin than AppKit for
|
||||
// screens stacked around the main display: per-display,
|
||||
@@ -452,6 +534,37 @@ final class ScreenCapture {
|
||||
height: rect.height
|
||||
)
|
||||
|
||||
// Window pick: capture the window DIRECTLY — the image comes
|
||||
// with the app's real rounded-corner alpha (no mask guessing).
|
||||
if let windowID,
|
||||
let scWindow = content.windows.first(where: { $0.windowID == windowID }) {
|
||||
var windowConfig = SCStreamConfiguration()
|
||||
windowConfig.width = Int(scWindow.frame.width * backingScale)
|
||||
windowConfig.height = Int(scWindow.frame.height * backingScale)
|
||||
windowConfig.showsCursor = false
|
||||
if let windowImage = try? await SCScreenshotManager.captureImage(
|
||||
contentFilter: SCContentFilter(desktopIndependentWindow: scWindow),
|
||||
configuration: windowConfig
|
||||
) {
|
||||
let expectedW = CGFloat(scWindow.frame.width) * backingScale
|
||||
let expectedH = CGFloat(scWindow.frame.height) * backingScale
|
||||
let overflow = max(
|
||||
CGFloat(windowImage.width) / max(expectedW, 1),
|
||||
CGFloat(windowImage.height) / max(expectedH, 1)
|
||||
)
|
||||
if overflow > 1.35 {
|
||||
// SCKit composited extra windows (owned popups etc.)
|
||||
// — reject and use the screen crop instead.
|
||||
CaptureController.log("capture: WINDOW id=\(windowID) overflow=\(overflow) (\(windowImage.width)x\(windowImage.height) vs \(Int(expectedW))x\(Int(expectedH))) — rejecting, using crop+mask")
|
||||
} else {
|
||||
CaptureController.log("capture: WINDOW id=\(windowID) image=\(windowImage.width)x\(windowImage.height) (native alpha corners)")
|
||||
completion(windowImage)
|
||||
return
|
||||
}
|
||||
}
|
||||
CaptureController.log("capture: window filter failed for id=\(windowID) — falling back to crop+mask")
|
||||
}
|
||||
|
||||
guard let image = try? await SCScreenshotManager.captureImage(contentFilter: filter, configuration: config) else {
|
||||
completion(nil)
|
||||
return
|
||||
|
||||
+2
-2
@@ -108,9 +108,9 @@ cat > "$APP/Contents/Info.plist" <<'PLIST'
|
||||
<key>CFBundleIconFile</key>
|
||||
<string>Icon</string>
|
||||
<key>CFBundleShortVersionString</key>
|
||||
<string>1.7.1</string>
|
||||
<string>1.8.6</string>
|
||||
<key>CFBundleVersion</key>
|
||||
<string>71</string>
|
||||
<string>86</string>
|
||||
<key>LSUIElement</key>
|
||||
<true/>
|
||||
<key>NSHighResolutionCapable</key>
|
||||
|
||||
Reference in New Issue
Block a user