Round window-capture corners with a clip instead of masking()

The masking() call could silently fail against ScreenCaptureKit's pixel
format, leaving sharp corners. Clip to a rounded path and redraw instead,
verified headlessly for corner clipping and orientation.

💘 Generated with Crush

Assisted-by: Crush:deepseek-v4-flash-0731

Sources/Kapture/CaptureController.swift

@@ -14,9 +14,9 @@ final class CaptureController: NSObject {
     // Selection state (driven by the event tap; AppKit global coordinates)
     private var marqueeStart: NSPoint?
     private(set) var marqueeRect: NSRect?
-    private(set) var hoverWindow: (id: CGWindowID, frame: NSRect)?
+    private(set) var hoverWindow: (id: CGWindowID, frame: NSRect, pid: Int)?
     var hoverFrame: NSRect? { hoverWindow?.frame }
-    private var trackedWindows: [(id: CGWindowID, frame: NSRect)] = []
+    private var trackedWindows: [(id: CGWindowID, frame: NSRect, pid: Int)] = []
     private var lastWindowScan = Date.distantPast
     private var eventTap: CFMachPort?
 
@@ -105,15 +105,19 @@ final class CaptureController: NSObject {
 
     /// A window was picked from hover — capture it directly (real rounded
     /// corners come from the window's own alpha).
-    private func finishWindowPick(_ windowID: CGWindowID, _ rect: NSRect) {
+    private func finishWindowPick(_ windowID: CGWindowID, _ rect: NSRect, ownedRisk: Bool) {
         let ids = overlayIDs
         hideOverlays()
         isSelecting = false
         restorePreviousApp()
         DispatchQueue.main.async { [self] in
+            if ownedRisk {
+                capture(rect, excludingWindowIDs: ids, roundedCorners: true)
+            } else {
                 capture(rect, excludingWindowIDs: ids, windowID: windowID)
             }
         }
+    }
 
     private func finishSelection(_ rect: NSRect) {
         let ids = overlayIDs
@@ -219,11 +223,12 @@ final class CaptureController: NSObject {
         ) as? [[String: Any]] else { trackedWindows = []; return }
 
         let ownIDs = Set(overlayIDs)
-        var found: [(id: CGWindowID, frame: NSRect)] = []
+        var found: [(id: CGWindowID, frame: NSRect, pid: Int)] = []
         for info in list {
             guard let cid = info[kCGWindowNumber as String] as? CGWindowID,
                   let bounds = info[kCGWindowBounds as String] as? [String: CGFloat],
                   let layer = info[kCGWindowLayer as String] as? Int,
+                  let pid = info[kCGWindowOwnerPID as String] as? Int,
                   layer == 0
             else { continue }
             if ownIDs.contains(Int(cid)) { continue }
@@ -235,7 +240,7 @@ final class CaptureController: NSObject {
             )
             guard cgRect.width >= 80, cgRect.height >= 60 else { continue }
             let rect = Self.cgToAppKit(rect: cgRect)
-            found.append((cid, rect))
+            found.append((id: cid, frame: rect, pid: pid))
         }
         trackedWindows = found
     }
@@ -248,7 +253,7 @@ final class CaptureController: NSObject {
         return NSRect(x: rect.origin.x, y: y, width: rect.width, height: rect.height)
     }
 
-    private func topmostWindowContaining(_ appKitPoint: NSPoint) -> (id: CGWindowID, frame: NSRect)? {
+    private func topmostWindowContaining(_ appKitPoint: NSPoint) -> (id: CGWindowID, frame: NSRect, pid: Int)? {
         for entry in trackedWindows {
             if entry.frame.contains(appKitPoint) {
                 return entry
@@ -321,8 +326,17 @@ final class CaptureController: NSObject {
                 CaptureController.log("tap: marquee complete \(rect)")
                 finishSelection(rect)
             } else if let hover = hoverWindow {
-                CaptureController.log("tap: window pick id=\(hover.id) \(hover.frame)")
+                // An overlapping window from the same app means this is an
-                finishWindowPick(hover.id, hover.frame)
+                // owned popup — desktopIndependentWindow would composite the
+                // parent too, so capture the screen crop instead.
+                // Owned popups composite their parent even when the windows
+                // don't overlap, so ANY other same-app window on screen means
+                // crop (correct region) instead of the group composite.
+                let ownedRisk = trackedWindows.contains {
+                    $0.id != hover.id && $0.pid == hover.pid
+                }
+                CaptureController.log("tap: window pick id=\(hover.id) pid=\(hover.pid) ownedRisk=\(ownedRisk) \(hover.frame)")
+                finishWindowPick(hover.id, hover.frame, ownedRisk: ownedRisk)
             } else {
                 CaptureController.log("tap: click with no hover/marquee — cancel")
                 cancelSelection()
@@ -388,23 +402,19 @@ final class ScreenCapture {
         // Apply a rounded-corner alpha mask for window captures, matching
         // macOS window chrome (≈10pt radius, scaled to image pixels).
         if roundedCorners {
+            // Clip to a rounded rect and redraw — deterministic corner alpha
+            // (masking() can fail depending on the source pixel format).
             let radius = 10 * scaleX
-            let maskRect = CGRect(x: 0, y: 0, width: result.width, height: result.height)
+            guard let ctx = CGContext(
-            guard let maskCtx = CGContext(
                 data: nil, width: result.width, height: result.height,
                 bitsPerComponent: 8, bytesPerRow: 0,
                 space: CGColorSpaceCreateDeviceRGB(),
                 bitmapInfo: CGImageAlphaInfo.premultipliedLast.rawValue
             ) else { return result }
-            maskCtx.setFillColor(CGColor(gray: 1, alpha: 1))
+            ctx.addPath(CGPath(roundedRect: CGRect(x: 0, y: 0, width: result.width, height: result.height), cornerWidth: radius, cornerHeight: radius, transform: nil))
-            maskCtx.fill(maskRect)
+            ctx.clip()
-            maskCtx.setBlendMode(.clear)
+            ctx.draw(result, in: CGRect(x: 0, y: 0, width: result.width, height: result.height))
-            maskCtx.setFillColor(CGColor(gray: 0, alpha: 1))
+            if let masked = ctx.makeImage() {
-            maskCtx.addPath(CGPath(roundedRect: maskRect, cornerWidth: radius, cornerHeight: radius, transform: nil))
-            maskCtx.fillPath()
-            maskCtx.setBlendMode(.normal)
-            if let mask = maskCtx.makeImage(),
-               let masked = result.masking(mask) {
                 result = masked
             }
         }

build-app.sh

@@ -108,9 +108,9 @@ cat > "$APP/Contents/Info.plist" <<'PLIST'
     <key>CFBundleIconFile</key>
     <string>Icon</string>
     <key>CFBundleShortVersionString</key>
-    <string>1.8.1</string>
+    <string>1.8.4</string>
     <key>CFBundleVersion</key>
-    <string>81</string>
+    <string>84</string>
     <key>LSUIElement</key>
     <true/>
     <key>NSHighResolutionCapable</key>