Make pasting reliable and turn items into checkboxes
Pasting still failed because the panel is a nonactivating panel: it can be key while the app is not active, and menu key equivalents are not delivered reliably in that state. Cmd+V is now dispatched to the responder chain directly, and the app no longer replaces SwiftUI's main menu — it only adds Hide Panel to it, so the Edit items that AppKit routes text shortcuts through stay intact. Rows also gained a checkbox so a workspace works as a checklist without turning the row into a button, which would swallow the checkbox's clicks.
This commit is contained in:
@@ -71,21 +71,27 @@ final class PanelController: NSObject {
|
||||
panel.setFrameOrigin(NSPoint(x: screen.maxX - size.width - 12, y: screen.minY + 12))
|
||||
}
|
||||
|
||||
// Intercept Cmd+V when the panel is key and the clipboard holds an image
|
||||
// (and no text, so normal text paste into the composer is unaffected).
|
||||
// Cmd+V is handled here rather than left to a menu key equivalent. The
|
||||
// panel is a nonactivating panel, so it can be key while the app is not
|
||||
// active, and menu key equivalents are not reliably delivered in that
|
||||
// state — which is what silently broke pasting. Dispatching paste: to the
|
||||
// responder chain ourselves removes that dependency.
|
||||
private func installPasteMonitor() {
|
||||
guard pasteMonitor == nil else { return }
|
||||
pasteMonitor = NSEvent.addLocalMonitorForEvents(matching: .keyDown) { [weak self] event in
|
||||
guard let self, let panel = self.panel, event.window == panel else { return event }
|
||||
let modifiers = event.modifierFlags.intersection(.deviceIndependentFlagsMask)
|
||||
if modifiers == [.command], event.charactersIgnoringModifiers == "v" {
|
||||
let pasteboard = NSPasteboard.general
|
||||
if pasteboard.string(forType: .string) == nil,
|
||||
let images = pasteboard.readObjects(forClasses: [NSImage.self], options: nil) as? [NSImage],
|
||||
let image = images.first {
|
||||
Task { @MainActor in Store.shared.addImage(image) }
|
||||
return nil
|
||||
}
|
||||
guard modifiers == [.command], event.charactersIgnoringModifiers == "v" else { return event }
|
||||
|
||||
let pasteboard = NSPasteboard.general
|
||||
if pasteboard.string(forType: .string) != nil {
|
||||
NSApp.sendAction(#selector(NSText.paste(_:)), to: nil, from: nil)
|
||||
return nil
|
||||
}
|
||||
if let images = pasteboard.readObjects(forClasses: [NSImage.self], options: nil) as? [NSImage],
|
||||
let image = images.first {
|
||||
Task { @MainActor in Store.shared.addImage(image) }
|
||||
return nil
|
||||
}
|
||||
return event
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user